I suggest replacing "Show Custom TitleBar", "Firefox option: Show TitleBar (almost) always present", and "System TitleBar always hidden" with the following, since the behavior of those options seems very confusing, inconsistent, and limits what can be done, as detailed further below.
Proposed Options for Clarity and Additional Control:
Look & Feel > "Titlebar" section
"Show Titlebar" =
Shown Always (default)
Shown only when Maximized (may not be commonly used or needed, less confusing than Hidden when Unmaximize)
Hidden when Maximized (less confusing IMO than Shown when Unmaximized)
Hidden (except for Dialogs) (may not be needed, but handles cases described in Show TitleBar always hidden = False tooltip)
Draw Tabs in Titlebar (built-in Firefox option)
Never gray out this option because it doesn't really seem to do much with whether or not titlebar is shown, but instead just changes behavior for dragging the window to move/resize, etc. (at least in the past, and this can be noted in the tooltip) and is required to change this to workaround issues I had reported in the past, and is used by other extensions, so should be able to change back here to fix them if had broken via this option in the past.
This option does not actually result in titlebar always being shown. In fact, it seems to have no affect with any combination of settings on whether or not the titlebar is shown.
Also, I suggest spelling TitleBar as "Titlebar" or "Title Bar" as PascalCase TitleBar isn't really used anywhere else and is a bit distracting IMO.
Currently its pretty confusing IMO and inconsistent in its behavior. Show Custom TitleBar = Never doesn't work unless have System TitleBar always hidden = checked.
Also, you can only set the Titlebar to Small/Thin for unmaximized widows via an option buried under there (Small (in unmaximized windows), instead of always having it be small, as I would prefer to do. I suggest making this a separate checkbox for Small/Thin Titlebar (or Titlebar Size = Thin/Normal).
Plus, the name Show Custom TItleBar makes it seem like its whether Firefox's built-in titlebar is used versus your custom replacement, when instead its really behaving like "Show Any TItlebar (which is always custom)".
Also, I suggest having "Firefox option: Show TitleBar (almost) always present" never be grayed out, regardless of what is chosen for "System Titlebar always hidden," because there are other implications for built-in Firefox behavior, ability to drag the Firefox window, some bugs/limitations I had reported previously for Hide Caption Titlebar Plus, and behavior for other extensions.
Also, I think that should be renamed because currently it doesn't really seem to make any difference in most cases for whether the titlebar is hidden. Instead, just rename it to "Show Tabs in Titlebar (Firefox built-in option)"
I suggest replacing "Show Custom TitleBar", "Firefox option: Show TitleBar (almost) always present", and "System TitleBar always hidden" with the following, since the behavior of those options seems very confusing, inconsistent, and limits what can be done, as detailed further below.
Proposed Options for Clarity and Additional Control:
Look & Feel > "Titlebar" section
"Show Titlebar" =
Titlebar Size =
Show Firefox Icon in Titlebar = (unchecked by default, because the page icon - which is far more useful - is shown next to this 2nd static useless icon - which just looks weird) You can use the [CSS I posted] (https://github.com/Javier-DarthPalpatine/firefox-hide-caption-titlebar-plus/issues/290#issuecomment-310879340) for issue #290, where others have requested this. In other words, this just hides .fxaustr_syscaption_only.
Draw Tabs in Titlebar (built-in Firefox option) Never gray out this option because it doesn't really seem to do much with whether or not titlebar is shown, but instead just changes behavior for dragging the window to move/resize, etc. (at least in the past, and this can be noted in the tooltip) and is required to change this to workaround issues I had reported in the past, and is used by other extensions, so should be able to change back here to fix them if had broken via this option in the past. This option does not actually result in titlebar always being shown. In fact, it seems to have no affect with any combination of settings on whether or not the titlebar is shown.
Also, I suggest spelling TitleBar as "Titlebar" or "Title Bar" as PascalCase TitleBar isn't really used anywhere else and is a bit distracting IMO.
Currently its pretty confusing IMO and inconsistent in its behavior. Show Custom TitleBar = Never doesn't work unless have System TitleBar always hidden = checked.
Also, you can only set the Titlebar to Small/Thin for unmaximized widows via an option buried under there (Small (in unmaximized windows), instead of always having it be small, as I would prefer to do. I suggest making this a separate checkbox for Small/Thin Titlebar (or Titlebar Size = Thin/Normal).
Plus, the name Show Custom TItleBar makes it seem like its whether Firefox's built-in titlebar is used versus your custom replacement, when instead its really behaving like "Show Any TItlebar (which is always custom)".
Also, I suggest having "Firefox option: Show TitleBar (almost) always present" never be grayed out, regardless of what is chosen for "System Titlebar always hidden," because there are other implications for built-in Firefox behavior, ability to drag the Firefox window, some bugs/limitations I had reported previously for Hide Caption Titlebar Plus, and behavior for other extensions. Also, I think that should be renamed because currently it doesn't really seem to make any difference in most cases for whether the titlebar is hidden. Instead, just rename it to "Show Tabs in Titlebar (Firefox built-in option)"