Morning session: Peer-to-peer code review

[didierganthier]

Peer-to-peer code review

• Review goes below

Wondering how to add a good review? Check this

[didierganthier]

Hi @OsvaldoBC and @KanzaTahreem, Your project is looking great. I really enjoyed reviewing it, it shows all the hard work displayed Congratulations! 🎉

Highlights

• The design fits the template. ✔️
• Good use of ES6 modules. ✔️
• Good use of GitFlow. ✔️
• Webpack configuration is good! ✔️
• I love the Slider 😁. ✔️

Optional suggestions

• [ ] The README.md should desscribe how someone can get an API KEY to test the project
• [ ] That's very optional but you should check the status of the response before getting the json(), in some cases the returned response is not JSON as well:
• https://github.com/KanzaTahreem/JavaScript-Capstone/blob/981163caf248f59409f46d6b39d780965a41bba3/src/modules/getMeals.js#L5
• [ ] I noticed some repetition in your CSS and you should avoid it in order to make the code DRY, for example:
• https://github.com/Javivy/js-capstone/blob/0ae2cce5ff8b455d0e3810ac4dce7017c986db46/src/style.css#L5 is repeated here after being set earlier for the whole project:
• https://github.com/Javivy/js-capstone/blob/0ae2cce5ff8b455d0e3810ac4dce7017c986db46/src/style.css#L66

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.