search

JaxGaussianProcesses / GPJax

Gaussian processes in JAX.
https://docs.jaxgaussianprocesses.com/
Apache License 2.0
436 stars 51 forks source link

Perhaps finally a decent LBFGS? #426

Closed henrymoss closed 9 months ago

henrymoss commented 9 months ago

I stole @daniel-dodd "back-of-the-envolope" implementation of a direct scipy minimize interface and fiddled it a bit.

It seems to work so much better (i.e. can optimize @thomaspinder's graph kernel).

Also means we can remove the jaxopt dependency

henrymoss commented 9 months ago

Something a bit weird happened when I updated my lock though!

thomaspinder commented 9 months ago

Looks like something has broken with the decoupled sampler?

henrymoss commented 9 months ago

Looks like something has broken with the decoupled sampler?

I managed to change the beartype version I think (when I deleted jaxopt). Fiddled the poetry files back to normal now

henrymoss commented 9 months ago

Actually @thomaspinder its still broken. I am unable to remove the jaxopt dependency in pyproject.toml without massive changes to my poetry.lock (hence changing the beartype version).

How should I be doing this? at the moment I do:

  1. poetry remove jaxopt
  2. poetry update
thomaspinder commented 9 months ago

I'm not 100% sure what's going on here. Why are you running poetry update though?