JaxkDev
commented
1 year ago Thanks Umeyyan for the review,
User input has now been added in the testing class to allow users to test all functionality.
For the Value and Suit validation as per other reviews I've moved into the setter for easier readability and concise validation.
Thanks for the review!
The project doesn't appear to have any syntax errors and is presented neatly and in a way that's easy to read and understand. The entire project matches the criteria of the project well. The use of comments throughout the project makes it easy to understand what each part of the project does and makes it possible to seamlessly navigate through the project, and a nice use of references where applicable.
One thing that could be improved on is getting a user input for the method of shuffling and number of cards that need to be dealt, that way the code can be used in more situations and problems.
I think line 21 and 22 should be surrounded by an if statement to double check that the inputs for value and suit are both within their respective ranges, for example:
if (v >= 1 && v <= 13 && s >= 1 && s <= 4) { Value = v; Suit = s; }