search

JayBizzle / Crawler-Detect

🕷 CrawlerDetect is a PHP class for detecting bots/crawlers/spiders via the user agent
https://crawlerdetect.io
MIT License
2.01k stars 258 forks source link

add crawler #513

Closed IT-Joris closed 1 year ago

JayBizzle commented 1 year ago

Failing test here @IT-Joris

I think you make need to escape the brackets in nbertaupete95(at)gmail.com

IT-Joris commented 1 year ago

Hello @JayBizzle, I made the corrections on my branch. Unfortunately the line Mozilla/5.0/Firefox/42.0 - nbertaupete95(at)gmail.com is present in the tests/devices.txt which makes the test user_agents_are_devices fail.

JayBizzle commented 1 year ago

Thanks, if you push those changes, ill rerun tests and get this merged 👍

IT-Joris commented 1 year ago

Hello @JayBizzle, as mentioned above, the tests don't work because the user agent is present in the device.txt folder. How can I fix this?

Because the user agent is considered a crawler.

JayBizzle commented 1 year ago

Just remove that line from devices.txt as you have now added it to crawlers.txt 👍

IT-Joris commented 1 year ago

The devices.txt file is read-only

IT-Joris commented 1 year ago

Sorry @JayBizzle, my IDE was blocking editing of the file, as it was too large, so I pushed the correction and testing successful through on my end.

JayBizzle commented 1 year ago

Ha, yeah, that file is fairly large 😬