search

JayChase / angular2-highlight-js

highlight.js integration with Angular
MIT License
21 stars 9 forks source link

peerDependencies angular/core: 2.0.0 #6

Closed oleg-sevenval closed 7 years ago

oleg-sevenval commented 7 years ago

npm always yells at me because I have a not matching peer dependency in my package.json. Is there a particular reason why you have set the peerDependence to the exact version of angular/core 2.0.0? Why not with the caret or tilde prefix?

JayChase commented 7 years ago

Hi. I've got some cleaning up to do to move the module to the latest recommendations for angular-cli. I'll leave this open and change the dependencies for the next version.

oleg-sevenval commented 7 years ago

Sounds good, thanks 👌

kokojvanko commented 7 years ago

Is there any ETA on when the next version is going to come out? Im trying to use this module with 2.4.3 and up and i cant. Thanks

JayChase commented 7 years ago

The peer dependencies are removed as of version 5.0.0. It makes it easier to maintain and I can't imagine many people trying to use the package without Angular x installed.

JayChase commented 7 years ago

There isn't too much I can do to control the change control in a directive. In the parent component you could the change detection strategy to OnPush to reduce the number of time ngAfterViewChecked gets called (see here for more information).