search

JayDDee / cpuminer-opt

Optimized multi algo CPU miner
Other
773 stars 545 forks source link

rejected shares on yescryptr8g at zergpool #261

Closed Quake4 closed 4 years ago

Quake4 commented 4 years ago

image

JayDDee commented 4 years ago

Reproduced. Works in v3.12.7. Under investigation.

JayDDee commented 4 years ago

I found the code that broke it but don't know why.

In v3.12.8 I eliminated a function in the stack that only allocated local storage before calling the hash function. Instead the storage is allocated by the calling function then the hash function is called directly. The change was believed to be trivial with no change in functionality. Although it works for all other yespower algos it doesn't work for r8g.

I analyzed the code in detail but found nothing to explain why the hash is invalid. Getting to the root cause would be nice but would involve extensive low level debugging.

Since the changes did not affect performance I will simply revert to the v3.12.7 code.

JayDDee commented 4 years ago

Fixed in v3.12.8.1.