JayFoxRox / xbox-tools

A collection of tools related to original Xbox
62 stars 11 forks source link

python-scripts: AC97 tracing is ugly #12

Open JayFoxRox opened 7 years ago

JayFoxRox commented 7 years ago

The code currently loops over all AC97 buffers, when the hard assumption for the logic is that there is only ever 1 buffer in existence. If AC97 buffer looping is done it should be the inner, not the outer loop.

Trace length + output path should be an argument.

The overall code quality is poor too.