Sketch Make Long Shadow plugin doesn't work

JayHoltslander / Sketch-Make-Long-Shadow

A plugin for Sketch to create long shadows of a user defined length from a shape.

MIT License

90 stars 14 forks source link

Sketch Make Long Shadow plugin doesn't work #4

Open nshelmuk opened 8 years ago

nshelmuk commented 8 years ago

Sketch version 39.1 (31720)

JayHoltslander commented 8 years ago

@abynim Do you have time to look into this?

lundzern commented 8 years ago

i can confirm this issue.

arnoesterhuizen commented 8 years ago

One thing I noticed is that the plugin requires "common.js", and that isn't copied over by default when the plugin is installed. When I copy common.js into the plugin folder manually, I get the dialog, but the action still doesn't apply.

Version 40.1 (33804)

martinbackes commented 7 years ago

hey there, is there going to be update version soon for Sketch 40.... Thanks :)

abynim commented 7 years ago

@JayHoltslander do you want to add me as a collaborator on this repo? I have the changes made already, just need permission to commit :)

lapidus commented 7 years ago

lundzern commented 7 years ago

Get Outlook for iOS

On Tue, Oct 25, 2016 at 3:04 PM +0200, "lapidus" notifications@github.com wrote:

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

knappdaddy commented 7 years ago

@abynim - i'm still having issues. did you merge?

WinayakBongarge commented 7 years ago

Not working on Sketch 41, Dialogue opens but its not adding shadow

joshuamanns commented 7 years ago

@abynim do you have a repo or branch with the updates I can use? Would be convenient!

abynim commented 7 years ago

Pushed a fix for Sketch 40 and above. Please test!

martinbackes commented 7 years ago

Hey, it works for me with Sketch Version 41.2 (35397), its just that Sketch still puts it into the "Legacy Plugins" folder. So as far as I know, Sketch thinks its outdated, right? Any idea why this is happening and how to fix this?

joshuamanns commented 7 years ago

@abynim thank you! It works well - I can confirm the legacy folder placement as well but that just has to do with how it was packaged up. Thanks again

abynim commented 7 years ago

Pushed another update with a fix for the legacy folder placement. Also added Sketch Runner integration. long-shadow

DarinJi commented 7 years ago

not working on sketch43

ZillieZephyr commented 7 years ago

Are there any plans to update this? I usually use OPO for illustrator to do this, but it is also broken at the moment.

Shyri commented 7 years ago

Just made a pull request in order to make it work for Sketch 44.1 https://github.com/JayHoltslander/Sketch-Make-Long-Shadow/pull/8

joakimmelkersson-ld commented 7 years ago

Not working in latest Sketch (45.2). Nothing happens when trying it. Any plans on fixing it?

JayHoltslander commented 7 years ago

Try now?

eledroos commented 7 years ago

Not working with Sketch 46.2 @JayHoltslander

thepixelparent commented 7 years ago

@JayHoltslander I can confirm as well this is still not working for Sketch 46.2. I was on 46.1 and was not working, just upgraded and still no working.

sbible commented 6 years ago

Also not working in Sketch 47.1. Dialog with options loads, but clicking "Make Shadow" doesn't do anything.

sqott-zz commented 6 years ago

^ same on 49.1