search

JayThomason / Tutti

Tutti is a shared music application for the car being made in conjunction with Audi.
3 stars 1 forks source link

MusicLibraryLoader thread is called with run instead of start #171

Closed JayThomason closed 10 years ago

JayThomason commented 10 years ago

I'm mostly just making this issue because I think it's kinda funny. The reason that our music loading is still slowing the app's boot process is because of this line:

  loaderThread.run();

We should be calling loaderThread.start(), which will actually run the thread asynchronously!

JayThomason commented 10 years ago

Fixed here: https://github.com/JayThomason/Tutti/commit/e5fec6a8dd3cb9af7195be352936e4c8f0993ce1

hwray commented 10 years ago

Lol silly mistake by me. One thing to check is that making this Async doesn't introduce any more errors. Does the UI update if the user creates a new Jam before all the music is loaded? What if someone tries to join the jam before all the masters local music is loaded?

JayThomason commented 10 years ago

Yeah the problem would be when someone joins the jam before the music has loaded

On Saturday, May 10, 2014, Harrison Wray notifications@github.com wrote:

Lol silly mistake by me. One thing to check is that making this Async doesn't introduce any more errors. Does the UI update if the user creates a new Jam before all the music is loaded? What if someone tries to join the jam before all the masters local music is loaded?

— Reply to this email directly or view it on GitHubhttps://github.com/JayThomason/Tutti/issues/171#issuecomment-42753045 .