Bug: setting track number in music library loader fails when track number column is null in phone music db

JayThomason / Tutti

Tutti is a shared music application for the car being made in conjunction with Audi.

3 stars 1 forks source link

Bug: setting track number in music library loader fails when track number column is null in phone music db #232

Closed JayThomason closed 10 years ago

JayThomason commented 10 years ago

see: https://github.com/JayThomason/Tutti/issues/231#issuecomment-44713795

hwray commented 10 years ago

Wow, crazy! I'm really surprised we haven't seen this bug before. Shouldn't be too difficult to add checks to the Library Loader for this and other values that we're relying on.

JayThomason commented 10 years ago

I haven't been able to recreate this yet. I can try to fix it but I won't know if it works.

hwray commented 10 years ago

Maybe @avptv can pull the code when you're done and test it out again with her brother's phone.

JayThomason commented 10 years ago

I pushed this commit https://github.com/JayThomason/Tutti/commit/8d8c668d84aa458569c7d5c41ac3ef7b450f125f -- it's worth testing it to see if it crashes. If needed I can upload another apk to my website.

avptv commented 10 years ago

Works on my brother's phone!! Woohoo!

hwray commented 10 years ago

Awesome stuff. Thanks for going on such an epic bug slaughter last night @JayThomason ! Rockstar.

rockstar