Bug: if you change your username in settings,

JayThomason / Tutti

Tutti is a shared music application for the car being made in conjunction with Audi.

3 stars 1 forks source link

Bug: if you change your username in settings, #233

Closed avptv closed 10 years ago

avptv commented 10 years ago

then it only updates if you go back by using the Top left "< Settings" button, but doesn't update if you click the bottom left back button

hwray commented 10 years ago

Can you clarify what you mean by "it updates"? Do you mean the welcome message on the home page, the SharedPreferences global var itself, or something else?
I remove the top left "back" button because it was giving us inconsistent behavior, so I don't think it should be activated if you pull the latest code. If you can, try to also remove the arrow graphic that we've had in the top-left since the beginning.

avptv commented 10 years ago

Yeah meaning if you're on the home screen and you click on Settings and change your username, then if you push the back button on the bottom left the welcome message doesn't update. And are you sure you removed it? I just pulled and it says Already up to date but I have the back button in the left corner on settings

hwray commented 10 years ago

That's to be expected. Even though the variable updates properly, we aren't sending any UI update signals to change the text on the main page.

If you're up-to-date, the back arrow on the Settings screen should definitely be disabled. I watched someone try to tap the arrow a few times during the alumni demo day, and I've committed the following lines to the onCreate in SettingsMenuActivity. Make sure you have these lines and everything else is up-to-date:

    getActionBar().setHomeButtonEnabled(false);
    getActionBar().setDisplayShowHomeEnabled(false);

JayThomason commented 10 years ago

fixed (https://github.com/JayThomason/Tutti/commit/f64b82193324b94bf4829b657c8ca16983b6e9a0)