search

JayVora-SerpentCS / OdooEduERP

Education ERP based on Odoo!
http://www.serpentcs.com
151 stars 181 forks source link

[ADD]migrated attendance module in v11 #89

Closed Arpit-SerpentCS closed 6 years ago

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Remove <!DOCTYPE html> from all the xml file. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/21e29e4365536e3237f30fd32ed1da9b0b24d529/school_attendance/wizard/attendance_sheet_wizard_view.xml#L2

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Remove line no 5 and add "_" in 3rd line. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/21e29e4365536e3237f30fd32ed1da9b0b24d529/school_attendance/wizard/student_attendance_by_month.py#L5

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Add domain in inside the search condition if it is used one time. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/1d1ffe1a9762d2ae1557a1059fbfdc8b2fff7a1f/school_attendance/models/school_attendance.py#L504, L505, L510

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Improve the README.rst file of a module. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/1d1ffe1a9762d2ae1557a1059fbfdc8b2fff7a1f/school_attendance/README.rst

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please use DEFAULT_SERVER_DATE_FORMAT instead of %Y-%m-%d in everywhere in the code. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_library/school_attendance/models/school_attendance.py#L212, L224, L396, L403, L489, L505, L581

Arpit-SerpentCS commented 6 years ago

@murtuzasaleh Please review it. Made improvements and tested the flow according to comments.

cc @JayVora-SerpentCS