search

JayVora-SerpentCS / OdooEduERP

Education ERP based on Odoo!
http://www.serpentcs.com
151 stars 181 forks source link

made improvements in school event #92

Closed Arpit-SerpentCS closed 6 years ago

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Improve the README.rst file of a module. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schoolevent/school_event/README.rst

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please add active_id inside the browse method. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schoolevent/school_event/wizard/terminate_reason.py#L13

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please remove line no 6 and add it on line no 5 https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schoolevent/school_event/models/event.py#L6 Exa.:- from odoo.exceptions import UserError, ValidationError

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please add domain inside the search view. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schoolevent/school_event/models/event.py#L216

Arpit-SerpentCS commented 6 years ago

@murtuzasaleh Please review the code. Made imnprovements and tested the flow locally according to the comments

cc @JayVora-SerpentCS