search

JayVora-SerpentCS / OdooEduERP

Education ERP based on Odoo!
http://www.serpentcs.com
151 stars 181 forks source link

made improvements in school transport module #96

Closed Arpit-SerpentCS closed 6 years ago

JayVora-SerpentCS commented 6 years ago

@AnuKPatel Do review

JayVora-SerpentCS commented 6 years ago

@Arpit-SerpentCS fix travis plz

JayVora-SerpentCS commented 6 years ago

fix travis plz

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Improve the README.rst file of a module. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/README.rst

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please remove hr and account from dependency. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/__manifest__.py#L12

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please add active_id inside the browse method. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/wizard/terminate_reason.py#L15

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Remove line no 4 and add _ in line no 3. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/wizard/transfer_vehicle.py#L4

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Remove line no 8 and add it in line no 7. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/models/transport.py#L8

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please add this portion in line no 64 https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/models/transport.py#L71, L72, L73

class TransportVehicle(models.Model): '''for vehicle detail''' _name = 'transport.vehicle' _rec_name = 'vehicle' _description = 'Transport vehicle Information'

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Add directly in line no L425 https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/models/transport.py#L424

Exa.:-mon1 = relativedelta(months=+rec.for_month)

murtuzasaleh commented 6 years ago

@Arpit-SerpentCS Please improved list name. https://github.com/Arpit-SerpentCS/OdooEduERP/blob/11.0_schooltransport/school_transport/models/transport.py#L445, L458, L465

Exa.:- vehi_participants_list, transport_list, trans_participants_list

Arpit-SerpentCS commented 6 years ago

@murtuzasaleh Please review the changes. Made improvements and tested the code according to the comments.

cc @JayVora-SerpentCS