Jayich-Lab / tray-launcher

A launcher for Windows that resides in the taskbar for managing .bat scripts.
MIT License
7 stars 1 forks source link

directory names #29

Closed fanmingyu212 closed 2 years ago

fanmingyu212 commented 2 years ago

Currently the log and scripts are saved in %userprofile%\tray_launcher. https://github.com/Jayich-Lab/tray-launcher/pull/20#discussion_r794226105 suggests to change it to .tray_launcher.

Also, should available_scripts be removed to scripts for simplicity?

danhuaxu commented 2 years ago

Oh shoot, I forgot to tray_launcher.

fanmingyu212 commented 2 years ago

I forgot to tray_launcher.

Don't worry. It is a small format thing that I am not 100% sure about.

danhuaxu commented 2 years ago

Currently the log and scripts are saved in %userprofile%\tray_launcher. #20 (comment) suggests to change it to .tray_launcher.

Also, should available_scripts be removed to scripts for simplicity?

I've changed the directory name to .tray_launcher. Now logs and scripts (previously available_scripts) are under %USERPROFILE\.tray_launcher.

Although the dot is added, I can still see the directory from my file explorer. I think this is expected because dot only hides the directory from ls command? That's what wikipedia tells me.

fanmingyu212 commented 2 years ago

Okay that sounds great. The dot would not hide the directory in Windows. It hides the directory in linux. I don't think there is a naming style that can hide the directory in Windows, but it is still good to follow what other software do (anaconda, docker, jupyter, labrad, matplotlib, vscode, etc.) by adding a dot.

danhuaxu commented 2 years ago

Okay that sounds great. The dot would not hide the directory in Windows. It hides the directory in linux. I don't think there is a naming style that can hide the directory in Windows, but it is still good to follow what other software do (anaconda, docker, jupyter, labrad, matplotlib, vscode, etc.) by adding a dot.

Yeah I will try to follow the conventions. If there are other conventions that I missed, plz let me know!