search

Jayich-Lab / tray-launcher

A launcher for Windows that resides in the taskbar for managing .bat scripts.
MIT License
7 stars 1 forks source link

terminate scripts upon tray launcher crashes? #43

Closed fanmingyu212 closed 2 years ago

fanmingyu212 commented 2 years ago

See https://github.com/Jayich-Lab/tray-launcher/issues/42#issuecomment-1038764408.

Does the scripts keep running correctly after a crash? Should we terminate the scripts?

fanmingyu212 commented 2 years ago

I am not sure the scripts should be terminated upon abnormal exit of the tray-launcher, although previously I thought they were being terminated. I am actually leaning towards not terminating them (if possible) to keep the mean-time-between-failure when running experiments longer.

danhuaxu commented 2 years ago

Scripts are not being terminated after the launcher crashed. At least that's what I saw when tested with a non_GUI script.

If this is more desirable, I guess no change should be made then. I will add a note in the README for sure.

fanmingyu212 commented 2 years ago

Scripts are not being terminated after the launcher crashed.

Yes I confirmed the behavior with jupyter notebook too. The current behavior seems good to me. A note in the README would be great.

danhuaxu commented 2 years ago

Ok, I will close this once I add to the README.

danhuaxu commented 2 years ago

Added to the README.