search

Jayich-Lab / tray-launcher

A launcher for Windows that resides in the taskbar for managing .bat scripts.
MIT License
7 stars 1 forks source link

Upload to PyPi #51

Closed danhuaxu closed 2 years ago

jayich commented 2 years ago

@danhuaxu can you add in the description what this is blocked by?

danhuaxu commented 2 years ago

Blocked by waiting for feedback from people in the lab.

fanmingyu212 commented 2 years ago

I would also solve #47 and #48 before uploading to pypi.

Also what is the credential we use for pypi? We should register a lab account for this.

fanmingyu212 commented 2 years ago

I think there is likely not much more feedback that is necessary to be resolved before uploading. Everything is good. Sam has tested this for a while on d7, and I tested this on enterprise and my computer too.

jayich commented 2 years ago

Registering a lab account makes sense.

Also, the project should be properly versioned, potentially with a badge right on the front and that number should start with a 0.X until it has been on pypi and we have tested ourselves for a significant amount of time.

jayich commented 2 years ago

So fix 47, 48, and get versioning cleaned up.

danhuaxu commented 2 years ago

Sounds good.

fanmingyu212 commented 2 years ago

See https://semver.org/ for versioning. I feel it is fine to set the pypi version to 1.0

jayich commented 2 years ago

This is still blocked though...

danhuaxu commented 2 years ago

Make all people contributed to the code (don't forget Kate) be coauthors in the initial commit to PyPi.