Jaykul / PowerLine

A more PowerShell prompt
MIT License
567 stars 31 forks source link

Fix right-aligned blocks #53

Closed andriniaina closed 3 years ago

andriniaina commented 5 years ago

This commit fixes right-aligned blocks in order to be closer to the unix shell implementation of Powerline.

Instead of adding a newline:

more details : ANSI_escape_code#Terminal_output_sequences

Jaykul commented 5 years ago

Apart from just copying someone else's implementation of this, is there actually something wrong with the current implementation that you're trying to fix?

andriniaina commented 5 years ago

What do you mean copying someone else's implementation?

Maybe I am doing something wrong but with the existing code, I see this

promptleft1>promptLeft2>                                          <promptRight1
# my commands are written here

I expect this:

promptleft1>promptLeft2> # my commands are written here          <promptRight1
andriniaina commented 5 years ago

look at ZSH's implementation of powerline

Image of Yaktocat

Jaykul commented 3 years ago

As far as I know, putting anything on the right side cannot work with PowerShell's readline, because it rewrites the whole line after the prompt...

andriniaina commented 3 years ago

It's OK. You can close the issue. I don't use powerline anymore.