Jaymon / bang

A static site generator with support for RSS feeds, sitemaps, and Google Amp
MIT License
13 stars 0 forks source link

Markdown v3.0 upgrade #37

Closed Jaymon closed 5 years ago

Jaymon commented 5 years ago

I think we're currently pegged at Markdown==2.6.9 because upgrading to Markdown==3.0.1 caused this error:

File "/usr/local/bin/bang", line 9, in <module>
  load_entry_point('bangtext==0.2.12', 'console_scripts', 'bang')()
File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 351, in load_entry_point
  return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2363, in load_entry_point
  return ep.load()
File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2088, in load
  entry = __import__(self.module_name, globals(),globals(), ['__name__'])
File "/usr/local/lib/python2.7/dist-packages/bang/__init__.py", line 8, in <module>
  from .generator import Site
File "/usr/local/lib/python2.7/dist-packages/bang/generator.py", line 12, in <module>
  from .types import Other, Aux, Post, Directories
File "/usr/local/lib/python2.7/dist-packages/bang/types.py", line 16, in <module>
  from .md import Markdown
File "/usr/local/lib/python2.7/dist-packages/bang/md/__init__.py", line 11, in <module>
  from .extensions.image import ImageExtension
File "/usr/local/lib/python2.7/dist-packages/bang/md/extensions/image.py", line 9, in <module>
    from markdown.inlinepatterns import ImagePattern as BaseImagePattern, \
ImportError: cannot import name ImagePattern

I couldn't find a specific mention of a name change in the release notes for v3.0 but looking at the code it might have been renamed to ImageInlineProcessor but I need to go through and make sure everything works as expected before supporting the markdown 3.0 branch