Jaymon / brow

Control Firefox or Chrome using Python
MIT License
3 stars 2 forks source link

Cookie handling is all over the place #1

Open Jaymon opened 6 years ago

Jaymon commented 6 years ago

Requests uses CookieJar but Selenium uses its own dict format. But since I added Selenium first I standardized on their format for brow.core.Cookies but I think it would be better to switch this and standardize on CookieJar because then I can use Python's built-in stuff like FileCookieJar to cache the cookies instead of the custom pickle solution I have now.

Maybe helpful links about cookies: https://stackoverflow.com/questions/1969232/allowed-characters-in-cookies https://docs.python.org/2/library/cookie.html (the other python Cookie lib)