Right now logrotate uses either :merge or :set and I think these should be combined to just basically act like merge. The idea being if you want to replace existing configuration you should just set the values to empty or nil.
Also, right now the logrotate recipe writes to a temp file, but it would be better to just add a to_s method to the supporting library class and then use Chef's file resource instead.
Right now logrotate uses either
:mergeor:setand I think these should be combined to just basically act like merge. The idea being if you want to replace existing configuration you should just set the values to empty ornil.Also, right now the logrotate recipe writes to a temp file, but it would be better to just add a
to_smethod to the supporting library class and then use Chef'sfileresource instead.