search

Jaymon / prom

A PostgreSQL or SQLite orm for Python
MIT License
22 stars 4 forks source link

looks like there might be a bug in all() #33

Closed Jaymon closed 8 years ago

Jaymon commented 8 years ago

if you specify a limit and an offset and then call all, it looks like it still moves through all the rows instead of the slice of rows delineated by limit, offset.

Jaymon commented 8 years ago

Looking at the codebase, this is by design:

This is smart about returning results and will use the set limit (or a default if no limit was set) to chunk up the results, this means you can work your way through really big result sets without running out of memory

But seems to be counter to how I think it should work intuitively, so I'm going to change it.