search

Jaymon / prom

A PostgreSQL or SQLite orm for Python
MIT License
22 stars 4 forks source link

DsnConnection should pass parsing dsn to interface #42

Closed Jaymon closed 6 years ago

Jaymon commented 7 years ago

It could first parse the interface modulepath and then use that to call modulepath.parse_dsn() which is a class method that will parse the dsn, this would allow the SQLite specific code to be moved out of DsnConnection.__init__ (the :memory: stuff) and the interface connection method that normalizes the path, host, and database variables, that could all be consolidated to the parse_dsn method.

Jaymon commented 6 years ago

This seems to have been fixed in 99bf32189d5273423483e3e48fcaa3f2f681477f, not sure why I didn't close this then