ugh, I can't tell you how many times this has annoyed me, prom.Model.modify takes both fields and fields_kwargs, so if you override it you have to call make_dict() yourself.
I think this should be changed so modify() will compress the values down to fields and then call another method like modify_fields (which currently exists but should be repurposed. That would make it so you don't every override modify but instead override modify_fields so you never have to worry about merging the fields and fields_kwargs variables.
ugh, I can't tell you how many times this has annoyed me,
prom.Model.modifytakes both fields and fields_kwargs, so if you override it you have to callmake_dict()yourself.I think this should be changed so
modify()will compress the values down tofieldsand then call another method likemodify_fields(which currently exists but should be repurposed. That would make it so you don't every overridemodifybut instead overridemodify_fieldsso you never have to worry about merging thefieldsandfields_kwargsvariables.