Jayne1010 / pe

0 stars 0 forks source link

Extra White space duplicate is not being checked #3

Open Jayne1010 opened 6 months ago

Jayne1010 commented 6 months ago

Screenshot 2024-04-19 at 4.18.00 PM.png

As shown here, when I add two similar inputs just with a different name with an extra whitespace, the application does not check for duplicate in such a case.

nus-pe-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

ug: add does not specify conditions of name uniqueness

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


in your app, add n/John Doe m/A1234567Z e/johnd@u.nus.edu tl/johndoe01 t/cs2109s t/G19Group1 and add n/John Doe m/A1234567Z e/johnd@u.nus.edu tl/johndoe01 t/cs2109s t/G19Group1

can both run successfully in succession. ( because of the additional spaces in name)

As a user, i would expect these names to be considered unique, but the UG does not tell me what is considered unique and what is not


[original: nus-cs2103-AY2324S2/pe-interim#3987] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Planned enhancements state that UUID is to be changed to matric number instead of name. Hence duplicate detection for names will not be needed in the future.

In the future, in the event that there are duplicate names, if matric numbers provided are the same, an error will be thrown since duplicate detection will be handled by the matric number.

Furthermore, if duplicate names are provided with different matric numbers, they will be accepted as 2 separate individuals with the same name, since their (unique) matric numbers are different.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** However, in version 1.4, name is still a uniqueness check as mentioned in your UG but there was not mention of it not being able to account for whitespace as it should. ![Screenshot 2024-04-23 at 11.14.48 AM.png](https://raw.githubusercontent.com/Jayne1010/pe/main/files/55f27f2f-1de1-4665-b689-062167acb211.png)