search

Jays2Kings / tachiyomiJ2K

Free and open source manga reader for Android
Apache License 2.0
4.53k stars 218 forks source link

[Bug] Manga don't load from links #1078

Closed Roccobot closed 2 years ago

Roccobot commented 2 years ago

Device information

Steps to reproduce

  1. Click on a manga link from any source supported by the installed extensions (Example)
  2. Choose to open with the proper Tachiyomi extension (if not already set as default)
  3. TachiyomiJ2K gets stuck on the loading screen and nothing else happens

Expected behavior

The manga should open in TachiyomiJ2K.

Actual behavior

TachiyomiJ2K opens but gets stuck on the loading page.

I can confirm this is not an issue for the original Tachiyomi, which I use as well: it properly opens manga links within the app.

The issue happens 100% of the times on all my devices, with any manga from any source, since the first version of TachiyomiJ2K I installed (1.1.0).

My other devices are a Xiaomi Mi Max 3 and a Lenovo tablet, both with Android 10.

Here's a little screen recording (UI is in Italian, sorry. 'Caricamento' means 'Loading')

TachiJ2K

Jays2Kings commented 2 years ago

can you provide what sources you have enabled, this seems to only happen to me if all sources have been disabled in the browse section

Roccobot commented 2 years ago

can you provide what sources you have enabled, this seems to only happen to me if all sources have been disabled in the browse section

Each device has a different extensions set, but for instance my main phone (Pixel 5) only has E-Hentai, MangaDex and Nhentai. BTW the issue happens with any set of sources (as far as I know).

I also tried to uninstall every extension except Mangadex (the one I use most of the time) but nothing changed.

notRyuk commented 2 years ago

The same happened to with all my extensions even though they are either disabled or enabled.

Jays2Kings commented 2 years ago

Do you have "search with only pinned sources" enabled in browse settings? because thats the only other way im able to replicate this. If this is on and the source isnt pinned, then I see this issue

If the issue is still there after that, you can share a screenshot here or dm me on discord of your browse screen so i can verify

notRyuk commented 2 years ago

No I don't have that enabled

Jays2Kings commented 2 years ago

If the issue is still there after that, you can share a screenshot here or dm me on discord of your browse screen so i can verify

@notRyuk then do this

notRyuk commented 2 years ago

image

Jays2Kings commented 2 years ago

I meant the browse screen that shows a list of your enabled sources

Also what device is this, because all of these sounds like device/rom issues, (the google pixel never got android 11, so i assume thats a custom rom)

notRyuk commented 2 years ago

Also what device is this, because all of these sounds like device/rom issues, (the google pixel never got android 11, so i assume thats a custom rom)

Yes kinda it is what I use is Windows Subsystem

notRyuk commented 2 years ago

I meant the browse screen that shows a list of your enabled sources

image

Seems fine in my mobile and tab though idk why I'm getting this error in the rom

Jays2Kings commented 2 years ago

message me on discord and ill see if we can resolve the issue, although WSA isnt officially supported so theres a chance the bug may remain

notRyuk commented 2 years ago

discord

Can I know the discord id/server link?

Jays2Kings commented 2 years ago

better yet ill upload a possible fix here, extract the apk from the zip and install over your current tachij2k. If it works you can keep the build until the next release. If it doesn't then this will just remain an open issue until im able to test WSA Removed apk as tests have been conducted

Roccobot commented 2 years ago

Do you have "search with only pinned sources" enabled in browse settings?

I had that option enabled and disabling it solved the issue for me! I'd prefer to have that behavior, but I can live without that if I get the link handling in exchange. Just tested on all my devices and it works fine everywhere. Thanks a lot, @Jays2Kings! I guess I should keep the issue open anyway, since @notRyuk still hasn't solved for their particular configuration

Jays2Kings commented 2 years ago

Do you have "search with only pinned sources" enabled in browse settings?

I had that option enabled and disabling it solved the issue for me! I'd prefer to have that behavior, but I can live without that if I get the link handling in exchange. Just tested on all my devices and it works fine everywhere. Thanks a lot, @Jays2Kings! I guess I should keep the issue open anyway, since @notRyuk still hasn't solved for their particular configuration

The zip I have has an attached fix, but you can wait for the next release and it'll work with pinned sources enabled

Roccobot commented 2 years ago

Fixed

notRyuk commented 2 years ago

Fixed for me in the zipped version. Thanks alot @Jays2Kings