search

Jays2Kings / tachiyomiJ2K

Free and open source manga reader for Android
Apache License 2.0
4.59k stars 220 forks source link

[Bug] The comic name is abnormal when the comic plugin Haomanwu is used in J2K #1202

Closed zhongfly closed 2 years ago

zhongfly commented 2 years ago

I have tested in https://github.com/tachiyomiorg/tachiyomi, the problem doesn't happen, but it happens in J2K version

Device information

Steps to reproduce

  1. install zh.haomanwu(好漫屋) 1.2.1

  2. open Popular Manga by click this extension in tachiyomiJ2K

  3. You can see that the manga names are normal (for the English demo, I searched for the keyword "love") image

  4. open one manga to see its detail(for example, we open Lovecraft Girls),the name is changed and is wrong (Lovecraft Girls 男生宿舍303 端脑（全彩版） 新极品全能高手 就吸你阳气！ 某天成为祭品公主 我什么时候无敌了 大国师 这个王爷他克妻，得盘! 成为王的男人 奇怪的情敌增加了) image

  5. Going back to the previous page, the names here are also tainted and become wrong image

Expected behavior

The manga name is displayed correctly as in the step 2(Lovecraft Girls), instead of being added a lot of extraneous characters at the end(男生宿舍303 端脑（全彩版） 新极品全能高手 就吸你阳气！ 某天成为祭品公主 我什么时候无敌了 大国师 这个王爷他克妻，得盘! 成为王的男人 奇怪的情敌增加了)

Actual behavior

The manga name is displayed like step 3 or 4, with lots of extraneous characters added at the end(男生宿舍303 端脑（全彩版） 新极品全能高手 就吸你阳气！ 某天成为祭品公主 我什么时候无敌了 大国师 这个王爷他克妻，得盘! 成为王的男人 奇怪的情敌增加了)

Other details

I have tested in https://github.com/tachiyomiorg/tachiyomi 0.13.3, the problem doesn't happen, but it happens in J2K version

zhongfly commented 2 years ago

The problem has been determined, the plugin uses the css selector to get the comic title, however the css seletor used can match multiple tags. In tachiyomi only the value of the first matching tag will be used, in J2K the values of all matching tags will be concatenated together.

I don't know if J2K is behaving correctly, so keep this issue open

anenasa commented 2 years ago

Oops. Maybe I should use first() next time.

In tachiyomi only the value of the first matching tag will be used

No, tachiyomi doesn't have this problem because title is not changed, no matter what title is set in mangaDetailsParse().

zhongfly commented 2 years ago

No, tachiyomi doesn't have this problem because title is not changed, no matter what title is set in mangaDetailsParse().

Thank you for your explanation, picacomic also has the problem that it cannot be used on J2K, can you solve it? https://github.com/Jays2Kings/tachiyomiJ2K/issues/1206