Jays2Kings / tachiyomiJ2K

Free and open source manga reader for Android
Apache License 2.0
4.55k stars 218 forks source link

Change to the app's font #1378

Open Xori71 opened 2 years ago

Xori71 commented 2 years ago

Describe your suggested feature

Have you ever thought of making the app's font static, as in not changing based on the font used for the System?

For example, you could use a Material Design compliant font, like Google Sans Text.

Other details

Example images: Screenshot_20220818-180830_TachiyomiJ2K~2 Screenshot_20220818-180848_TachiyomiJ2K~2 Screenshot_20220818-180824_TachiyomiJ2K~2

Acknowledgements

RokeJulianLockhart commented 5 months ago

https://github.com/Jays2Kings/tachiyomiJ2K/issues/1378#issue-1343254001

@Xori71, why would this be desirable? It would be hideous for anyone with accessibility needs, and unexpectedly inconsistent for anyone else. If applications don't adhere to system preferences, why do those preferences exist...?

Xori71 commented 5 months ago

#1378 (comment)

@Xori71, why would this be desirable? It would be hideous for anyone with accessibility needs, and unexpectedly inconsistent for anyone else. If applications don't adhere to system preferences, why do those preferences exist...?

Fair point, but sometimes it is desirable for an app to has its own design language, irrespective of user choice.

RokeJulianLockhart commented 5 months ago

https://github.com/Jays2Kings/tachiyomiJ2K/issues/1378#issuecomment-2030794227

@Xori71, when and why? That's totally unsubstantiated, especially considering the detriment to accessibility.

Xori71 commented 5 months ago

#1378 (comment)

@Xori71, when and why? That's totally unsubstantiated, especially considering the detriment to accessibility.

Do Google apps conform to your font choices? Do most websites?

Mihon and its forks are going for a Material Design look, and Material Design has guidelines that are to be followed in order to achieve a complete look.

My post wasn’t a demand. It was a suggestion from a design standpoint. It makes sense for J2K to use a font that conforms to Material Design guidelines.

RokeJulianLockhart commented 5 months ago

https://github.com/Jays2Kings/tachiyomiJ2K/issues/1378#issuecomment-2030802368

Yes, @Xori71, every website adheres to https://support.mozilla.org/en-US/kb/change-fonts-and-colors-websites-use#w_custom-fonts (https://news.ycombinator.com/item?id=32875519 explains this feature well) and every local application that I've utilized conforms to what https://invent.kde.org/plasma/plasma-desktop/-/blob/e5e5f5ed51aadfac99bfbdf3d2db5be16a12443b/kcms/fonts/fontssettings.kcfg#L7-82 defines. What you describe is why so many must ask questions like https://www.reddit.com/r/GooglePixel/comments/6de01x/change_system_font_without_rooting/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button.

Additionally, https://m3.material.io/styles/typography/fonts#dbd29949-f164-4065-bb36-49a765fbfe3d specifically states that the default system font is M3+You-conformant (else it would not be listed in the Material 3 subdomain).

Regardless, if this were to be implemented, perhaps we could at least set https://developer.android.com/reference/android/view/View#attr_android:importantForAccessibility (per https://developer.android.com/guide/topics/ui/accessibility/principles#decorative) if that would make any difference.