Jays2Kings / tachiyomiJ2K

Free and open source manga reader for Android
Apache License 2.0
4.6k stars 220 forks source link

[Bug] Migrating source sometimes, without warning, deletes the manga instead #174

Closed GreatestFool closed 2 years ago

GreatestFool commented 4 years ago

Device information

Steps to reproduce

Seems to happen sporadically or seemingly at random. Migrate enough and you'll notice if you're looking for it.

Expected behavior

Not deleting the comic from My Library without adding new source.

Actual behavior

Considering how this is happening, I'm assuming code-wise, it simply removes the old source from My Library and adds the new source while remembering/importing things like read chapters, tracking and the like. As is, it seems to yeet some out of existence and not proceeding with adding the new source.

Other details

Noticed this while I was doing a single-comic source migration on one called Tensei Kenja wa Musume to Kurasu. This was a day or so after migrating from kissmanga on about twenty or so comics, Re:Monster is the only one I can say for certain was in my library beforehand, but my memory is shit so I can't really check how far reaching it actually is. From a gut feeling and a fair sense in deja vu, at least three of the original mass migration encountered this issue.

Is gladly check closer by restoring from a backup, but with the tracking issue being like it is it isn't really worth the pain lol.

joseph619 commented 3 years ago

Does this still happen on J2K 1.10.16?

GreatestFool commented 3 years ago

Unfortunately, this is likely to remain stale. I never bulk-migrate because of this and have been keeping track of the ones I have during the migration so I can't say for certain and I'm not willing to test this simply because losing any of them would be a pain. At the very least, if this does happen it is rare or something specific to bulk-migrating as opposed to individual-migration as I've been dealing with for the most part.