search

JaysGitLab / cs-5666-scatt-jacc-caj

cs-5666-scatt-jacc-caj created by GitHub Classroom
1 stars 1 forks source link

Iss15 #20

Closed bclinthall closed 7 years ago

bclinthall commented 7 years ago

This tests and implements #13, #14, and #15.

bclinthall commented 7 years ago

@whereswaldon, github is showing a ton of changed code in this pull request, much of which you've already reviewed in the CountSprites pull request. I wonder if it will update the changed code page when CountSprites gets merged. I hope so.

whereswaldon commented 7 years ago

@bclinthall, you're right that this is a painful amount of code to review. Sadly, it isn't any cleaner now that we've merged that other PR. I'm gonna rebase these changes on master and then open a new PR to review only the real changes.

bclinthall commented 7 years ago

Okay, I'm closing this pull request in favor of the rebase.