search

JaysGitLab / cs-5666-scatt-jacc-caj

cs-5666-scatt-jacc-caj created by GitHub Classroom
1 stars 1 forks source link

Iss4 #29

Closed ejcole closed 7 years ago

ejcole commented 7 years ago

Check this out. Major hack and slash. It is pretty now.

whereswaldon commented 7 years ago

Also, once we merge this I will package a release as per our README usage instructions.

whereswaldon commented 7 years ago

Are we planning to test the UI at all? Currently, this PR doesn't seem to be adding any tests.

bclinthall commented 7 years ago

I'd like to test functionality that relies on a FileChooser. Note that FileChooser is now an interface and GuiFileChooser implements it. Because of the way we've been working in parallel and decoupling, there isn't currently any functionality that depends on a FileChooser. One of the next things I hope to do next is to write some code that glues our pieces together and (before that) write some tests to make sure they glue together well. Those tests can make sure that we can respond properly to a path returned from a FileChooser. We'll make sure we do well when it is a good directory full of sb2's and also when it is something weird (including null which is what a GuiFileChooser would do if the user clicked cancel). In my opinion, that is as close as we should get to testing the UI. I'm pretty sure that was Fenwick's advice too.