search

JaysGitLab / cs-5666-scatt-jacc-caj

cs-5666-scatt-jacc-caj created by GitHub Classroom
1 stars 1 forks source link

Iss34 #36

Closed bclinthall closed 7 years ago

bclinthall commented 7 years ago

To resolve #34 and #35.

bclinthall commented 7 years ago

Funny. This is passing all tests and checks on my laptop, but not on Travis. Does it fail for any of you if you download and try to build? @whereswaldon @ejcole @thehunte199

thehunte199 commented 7 years ago

The reason travis is failing seems to be due to checkstyle errors, I'll modify things to be appropriate for checkstyle.

thehunte199 commented 7 years ago

checkstyle now passing, testfilegoodpathcase is failing

thehunte199 commented 7 years ago

@bclinthall @whereswaldon Added @Test modifier above testEndToEnd to see if this was the reason the test was failing, now it seems that the get Sprites script count and length tests are failing. Unsure if this is because these have been modified in some way. Let me know what you find. Note: I created a second branch iss34-testing to test this since I was modifying more than just checkstyle errors.

whereswaldon commented 7 years ago

@bclinthall Are you working on this, or does someone else need to take a look?

bclinthall commented 7 years ago

I am not working on it yet, but plan to after I get the kids to bed.

On Apr 10, 2017 4:46 PM, "Christopher Waldon" notifications@github.com wrote:

@bclinthall https://github.com/bclinthall Are you working on this, or does someone else need to take a look?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JaysGitLab/cs-5666-scatt-jacc-caj/pull/36#issuecomment-293073859, or mute the thread https://github.com/notifications/unsubscribe-auth/AYFPuNsRIGPur2MCpETPBYiEvj24xXtaks5rupVCgaJpZM4M2YZ3 .

bclinthall commented 7 years ago

Finally got this one to pass Travis. File.listFiles() was giving us sb2's in a different order on our machines and on Travis's. :-( I wish I had figured that out more quickly.