search

JaysGitLab / cs-5666-scatt-jacc-caj

cs-5666-scatt-jacc-caj created by GitHub Classroom
1 stars 1 forks source link

Iss48 #54

Open thehunte199 opened 7 years ago

thehunte199 commented 7 years ago

Modified oddCombo and WizardReport.txts to include global and sprite level variable counts Modified reporter tests to include reporting of variables Implemented reporting of variables functionality in reporter

Tests not passing, but when I actually run the program it seems our program is outputting what I expect except the file name is off (which isn't something I modified)... Would anyone mind giving this a once over/running this to help find what's wrong? @whereswaldon @ejcole @bclinthall

whereswaldon commented 7 years ago

@thehunte199 This is failing tests because the report contents aren't matching what the tests are expecting. I'm having trouble identifying the difference because Utils.diffStrings() is a little hard to read. I'll post again if I find out more.

whereswaldon commented 7 years ago

Ah, now I understand what you mean by "the file name is off". The wizard sb2 test fails because diff actual expected is

6c6
< Project 1: WizardProject
---
> Project 1: WizardSpells.sb2

So we're getting WizardProject as the filename when our tests expect WizardSpells.sb2. Which is correct? @bclinthall @ejcole @thehunte199

whereswaldon commented 7 years ago

@thehunte199 What's the status here?

thehunte199 commented 7 years ago

Still having Issues with the renaming of the files. The modifications I made should not have affected the reporting of the files and I'm now wondering if there's some error that I have made which I have been unable to notice or if there is a bug hidden somewhere deeper (less likely). Eric said he would try to find the bug but it seems neither of us have been able to. @whereswaldon @bclinthall care to give it a look?