haietza
commented
6 years ago @patrickbeekman I fixed the error we were seeing this morning by adding the model to the config/mongoose.js file.
I made a few more changes in addition to the ones we did together this morning from the original pull request code review:
- Changed the dateCreated field to created, so it is consistent with the user model
- Removed mongoose from eventType type (not needed since we reference mongoose as part of Schema variable above)
- Fixed the date validator so it correctly calculates the valid end date based on eventType maxNumberOfDays
- Removed month and year equality check in date validator (an event could go from the last day of one month/year to the first day of the next and still be valid)
The tests are all now passing. Take a look and if these changes are okay with you, let me know and I'll approve the pull request and merge the branch into master. Thanks!
caldwellc1
Resolving issue #6
Created the reservation model and added tests to it. I added some date validation to check the startTime is before the endTime of the reservation and to take into account the maxAmountOfDays variable based on the eventType. I am not sure how this test case will react when the startTime and endTime are two different months eg. start=April 30th end=May 1st?