Remove unnecessary null pointer checks

[elfring]

Extra null pointer checks are not needed in functions like the following.

• FoliageItem
• Mesh
• TextureCubemap

[manav-06]

hi, @elfring you can assign this to me

[elfring]

:thought_balloon: Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

[manav-06]

Yeah sure

[Jaysmito101]

@manav-06 Are you interested in fixing this up?

[manav-06]

Yeah

[Jaysmito101]

@manav-06 Alright i am assigning this issue to you.

[suyashmadhesia]

@Jaysmito101 is this issue completed? I want to work on this issue. Can you please assign this issue to me ?

[Jaysmito101]

@suyashmadhesia alright

[suyashmadhesia]

Extra null pointer checks are not needed in functions like the following.

• FoliageItem
• Mesh
• TextureCubemap

So I have to remove null pointer check in given these three files ?

[Jaysmito101]

@suyashmadhesia not just these but throughout the entire project. Those are just some examples.

[elfring]

So I have to remove null pointer check in given these three files ?

I proposed a change (at such source code places at least). :thought_balloon: Would the linked information sources motivate you to check if more update candidates can be improved accordingly?

[suyashmadhesia]

@elfring @Jaysmito101 Got it. I have to find and remove all unnecessary null pointer checks throughout the code base.

[elfring]

:thought_balloon: Are you going to select any tools which can be more helpful for such a development task?

[suyashmadhesia]

@elfring I don't know much but I will be using Visual Studio for debugging and development. If you have any suggestions please help me I am a beginner to open source contribution with little knowledge of gdb and intermediate knowledge of C++.

[elfring]

If you have any suggestion …

:thought_balloon: Did you notice any previous links to the development tool “clang-tidy”?

[suyashmadhesia]

Yes. It showing static member function. Can you please explain it more like what you are trying to explain me.

[elfring]

It showing static member function.

:thought_balloon: I wonder about such an information.

• Would you like to try clang-tidy out on the command line?
• Did you configure this tool as a plug-in for any integrated development environments?

[suyashmadhesia]

Maybe, let me try it by myself if I got stuck at any point I will ask it out

[Yashs1623]

Hey @Jaysmito101, can you please assign this issue to me

[Captain2234]

hey @jaysmitho can you assign this issue to me if it is not solved yet

[Jaysmito101]

This issue will be fixed with later pushes.