search

Jayy001 / codexctl

Automated update managment for the ReMarkable tablet
GNU General Public License v3.0
108 stars 13 forks source link

On rM the default downloads folder doesn't exist #79

Open multijoy opened 6 months ago

multijoy commented 6 months ago

As title - trying to download onto a 3.11 in order to rollback to the 2. series to install Toltec, however fails with "cannot find download folder" and creating the folder in the current directory doesn't see a file downloaded

Cancel my last, it is expecting to see "./Downloads"

Eeems commented 6 months ago

What OS are you on? It should not be looking for the folder named Downloads in your local directory, it should be using either the folder specified by the XDG_DOWNLOAD_DIR environment variable, or the folder named Downloads in your home directory if the environment variable is not set.

https://github.com/Jayy001/codexctl/blob/5c5b5119d3f81121edd870424cffb0d65df3011b/codexctl/updates.py#L16-L23

Eeems commented 6 months ago

I see you saying that it's "On device", but it's failing because the folder doesn't exist. It would be fair to add extra code to have a better sane default for running on the device, as well as making sure the folder exists.