search

Jazea / Onvif.Core

A lightweight ONVIF Discovery and Client library.
MIT License
71 stars 26 forks source link

BugFixes related to discovery #17

Closed kumaakh closed 4 months ago

kumaakh commented 6 months ago
  1. Constants.cs => Bad Probe Template fixed, changed the default timeout to 15 seconds (5000 seconds is too long for any usage)
  2. DiscoveryService.cs => was raising ConcurrentModification exception as Except() function only returns a view on the original list,fixed
  3. DiscoveryDevice.cs => the equals operator was broken, changes to a string match.
brantonb commented 4 months ago

I'd love to see this get merged in so I can use discovery without such a long timeout. Ideally, I could optionally pass in a timeout. I'm currently using a second ONVIF library for discovery, which I'd prefer to drop.

kumaakh commented 4 months ago

The DiscoveryDevice.equals change done on master was covering the failing case I found, hence used the master version and backed off my changes. The code should merge now.