search

Jazqa / kwin-yakts

An easy tiling script for KWin
GNU General Public License v2.0
368 stars 20 forks source link

Conflict with plasma-applet-active-window-control #44

Closed kupiqu closed 7 years ago

kupiqu commented 7 years ago

I noticed that there is a conflict between this script and plasma-applet-active-window-control when using the option "hide titlebar for maximized windows".

To reproduce it:

expected behavior is that the window would come back to be maximized without the titlebar

however, when using the tiling script, the window is restored to a tile

this would not be a problem (I actually like the tiling better than to restore to the maximized window) if the window would recover the titlebar, which is not the case

is there a way to retore maximized windows from minimization to a tile, while getting back the titlebar at the same time?

Currently, to get back the titlebar, I have to go to buttons of plasma-applet-active-window-control and restore from maximization, even if the window is not maximized anymore.

Jazqa commented 7 years ago

If I had to guess, the same happens with fullscreen clients even without the extension. Minimizing and then restoring a client is probably not checking if the restored client is maximized/fullscreen. Should be a simple fix, I'll give it a try as soon as I get home.

is there a way to retore maximized windows from minimization to a tile, while getting back the titlebar at the same time?

I'm afraid not. I can not maximize or unmaximize a window via the script. Hell, the script can't even know whether a window is maximized or not without comparing its size to the available screen size (see #17). Maximized windows is one of the biggest issues I've had with the script.

kupiqu commented 7 years ago

Should be a simple fix, I'll give it a try as soon as I get home.

Thank you

Jazqa commented 7 years ago

Wow, I didn't even need to get home to fix this. Look at this sick commit. All I needed to do was add a word. I don't actually use Active Window Controls but the issue existed even without it, so hopefully it's working for you now as well.

Once again, thanks for reporting the bug, you've been a huge help since the beginning of the script!

kupiqu commented 7 years ago

Awesome, many thanks!