search

Jbwasse2 / topological-mapping

Topological Maps on Real World Robot
0 stars 0 forks source link

Test Refactor RCLPY cleanup #25

Open Jbwasse2 opened 3 years ago

Jbwasse2 commented 3 years ago

Currently each test calls rclpy.init, rclpy.shutdown, and handling killing of rosnodes. It would be nice if the tests could be refactored such that. 1) When tests are ran rclpy init and shutdown are called by some function that starts before testing and after testing respectively 2) Between each test a function is called to kill ALL ros1 and ros2 nodes created during testing. 3) Create a function that determines if roscore/rosbridge is running. If they aren't start them respectively.

Jbwasse2 commented 3 years ago

1 finished in #31

Jbwasse2 commented 3 years ago

3 is done, it doesn't start it though, just warns the user.