Jc2k / aiohomekit

asyncio for homekit
Apache License 2.0
52 stars 20 forks source link

Ignore stale encrypted notifications #313

Closed bdraco closed 1 year ago

bdraco commented 1 year ago

If we press a button or have an event while connected, the GSN increments, but as soon as we disconnect we can also get an encrypted notification for that GSN which we need to ignore as its stale and we already processed it as otherwise we see the button press twice

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03% :warning:

Comparison is base (38b4eed) 67.44% compared to head (2adc65a) 67.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #313 +/- ## ========================================== - Coverage 67.44% 67.41% -0.03% ========================================== Files 72 72 Lines 6829 6832 +3 ========================================== Hits 4606 4606 - Misses 2223 2226 +3 ``` | [Files Changed](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [aiohomekit/controller/ble/pairing.py](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWlvaG9tZWtpdC9jb250cm9sbGVyL2JsZS9wYWlyaW5nLnB5) | `22.33% <0.00%> (-0.09%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.