Jc2k / aiohomekit

asyncio for homekit
Apache License 2.0
52 stars 20 forks source link

Strip out iid 0 from the linked services list #328

Closed bdraco closed 1 year ago

bdraco commented 1 year ago

Devices should never send iid 0, but they do

related issue https://github.com/home-assistant/core/issues/99306

bdraco commented 1 year ago

DRAFT since I'm traveling and can't manually retest pairing right now

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa14889) 67.43% compared to head (d35ebf0) 67.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #328 +/- ## ======================================= Coverage 67.43% 67.43% ======================================= Files 72 72 Lines 6839 6839 ======================================= Hits 4612 4612 Misses 2227 2227 ``` | [Files Changed](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [aiohomekit/controller/ble/pairing.py](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWlvaG9tZWtpdC9jb250cm9sbGVyL2JsZS9wYWlyaW5nLnB5) | `22.38% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 1 year ago

Discussed on discord and this is good to go once manual retest passes

bdraco commented 1 year ago

TODO

bdraco commented 1 year ago
Screenshot 2023-09-02 at 2 18 05 PM