Jc2k / aiohomekit

asyncio for homekit
Apache License 2.0
52 stars 20 forks source link

Workaround invalid minStep values #332

Closed Jc2k closed 1 year ago

Jc2k commented 1 year ago

Currently if minStep is present but 0 it causes a division error. 0 is not a valid value for minStep, so bypass clamping as if it wasn't there at all.

Fixes https://github.com/home-assistant/core/issues/100183.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (415f616) 67.88% compared to head (0a5ead7) 67.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #332 +/- ## ======================================= Coverage 67.88% 67.88% ======================================= Files 71 71 Lines 6775 6775 ======================================= Hits 4599 4599 Misses 2176 2176 ``` | [Files Changed](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [aiohomekit/model/characteristics/characteristic.py](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWlvaG9tZWtpdC9tb2RlbC9jaGFyYWN0ZXJpc3RpY3MvY2hhcmFjdGVyaXN0aWMucHk=) | `76.78% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.