Jc2k / aiohomekit

asyncio for homekit
Apache License 2.0
52 stars 20 forks source link

Try harder to avoid missing button presses #336

Open bdraco opened 1 year ago

bdraco commented 1 year ago

maybe fixes #319

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c244405) 67.99% compared to head (85f2e58) 68.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #336 +/- ## ========================================== + Coverage 67.99% 68.00% +0.01% ========================================== Files 71 71 Lines 6781 6780 -1 ========================================== Hits 4611 4611 + Misses 2170 2169 -1 ``` | [Files](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [aiohomekit/controller/ble/pairing.py](https://app.codecov.io/gh/Jc2k/aiohomekit/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YWlvaG9tZWtpdC9jb250cm9sbGVyL2JsZS9wYWlyaW5nLnB5) | `22.40% <0.00%> (+0.02%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 1 year ago

This fixes the missed button presses but now I get duplicates

So if I do

4, 5, 3

4 is broadcast as adv and fired 5 isn't and generates a disconnected event

It connects and reads 4,5,3 so 4 gets fired again