Build for multiple versions of Minecraft

Jckf / DH-Support

Server-side support for Distant Horizons.

https://dhs.jckf.no

63 stars 0 forks source link

Build for multiple versions of Minecraft #48

Closed Jckf closed 3 months ago

Jckf commented 3 months ago

Closes #47

kccricket commented 3 months ago

@Jckf Forgive the intrusion, because I'm not an experienced plugin developer. But, what's the benefit to building multiple jars this way, rather than building one jar that simply avoids using Spigot/Bukkit API features that aren't supported in the earliest version of Minecraft you're targeting? It's my understanding that the api-version property indicates the earliest API version the plugin is targeting, rather than the actual version of the API it's built against.

Jckf commented 3 months ago

@kccricket There is currently no real benefit, because I am not utilizing it to introduce any changes to the code. Distant Horizons has some differences between versions, so it could become necessary, but their devs are working on making it more consistent 🙏

nikp123 commented 3 months ago

Also for clarity sake, in case you run into a version earlier than 1.20.6 (AFAIK) you'll need to specify a broader API version (ie. 1.20) in the pom file for it to be properly be recognized by Bukkit/PaperMC/etc.

Jckf commented 2 months ago

@nikp123 We spoke on Discord, but just so the conversation exists on Github as well: This was addressed here https://github.com/Jckf/DH-Support/commit/e5989134cc268fbec5d05ba438226ecc8c1d0bd7 :)