search

Jcw87 / c2-sans-fight

Undertale Sans Fight Clone
http://jcw87.github.io/c2-sans-fight/
538 stars 521 forks source link

Update index.html #44

Closed Macleykun closed 6 years ago

Macleykun commented 6 years ago

Added declaration of language. removed chrome=1. (https://stackoverflow.com/questions/22059060/is-it-still-valid-to-use-ie-edge-chrome-1) removed type spec for inline style. removed touch-action-delay: none;

reason: Using a more valid index.html file :-) https://validator.w3.org/ https://jigsaw.w3.org/css-validator/ (ignoring the ms vendor attributes)

Jcw87 commented 6 years ago

The index.html file gets generated by Construct 2. The various tags and attributes exist to try and keep compatibility with as much as possible. A lot of research and testing has gone into it, and I would rather not mess with it. Old browser compatibility is a minefield I'm not interested in stepping into. The most I will do in this area is re-export with a newer version of Construct 2. Additionally, any changes made to the html will have to be re-applied every time I export the project. I already have to do this with the google analytics script and the search engine metadata. I really don't need more on top of that.

Macleykun commented 6 years ago

Np, closing pull later today :-)

Outlook voor iOShttps://aka.ms/o0ukef downloaden

From: Jcw87 notifications@github.com Sent: Wednesday, August 15, 2018 3:23:17 AM To: Jcw87/c2-sans-fight Cc: Macley; Author Subject: Re: [Jcw87/c2-sans-fight] Update index.html (#44)

The index.html file gets generated by Construct 2. The various tags and attributes exist to try and keep compatibility with as much as possible. A lot of research and testing has gone into it, and I would rather not mess with it. Old browser compatibility is a minefield I'm not interested in stepping into. The most I will do in this area is re-export with a newer version of Construct 2. Additionally, any changes made to the html will have to be re-applied every time I export the project. I already have to do this with the google analytics script and the search engine metadata. I really don't need more on top of that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Jcw87/c2-sans-fight/pull/44#issuecomment-413065933, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZKMc-upM8bJ6wl4-WBvKjjDR1ikkbEGks5uQ3gFgaJpZM4V8KrH.