search

Jcw87 / c2-smb1

Super Mario Bros Clone
46 stars 49 forks source link

Add mobile support #1

Open Enovale opened 7 years ago

Enovale commented 7 years ago

Hey it's me again lol. I was hoping you could add touch controls to this game in the same way you did with the sans fight. Or at least simalar. I re hosted your games on my site (I stated that it was a reupload, the site isn't posted anywhere publically, and I only did it so that my friends and I can play them at school) and they saw that I convinced you to add touch controls to the sans fight and now they want me to do the same with this mario game. I'm sorry if you don't like that I re uploaded this but like I said my friends are the only ones who know what the site is.

Jcw87 commented 7 years ago

It doesn't matter if you only gave links to your friends. It's still publicly accessible. And it's not even hard to find. Knowing how github pages work, I can start with https://elijahzawesome.github.io/, which links to https://elijahzawesome.github.io/c2-meme-fight/, or I can just go directly there because of github pages knowledge again.

When I say you can host it in a private location, I mean either directly from the filesystem (works in Firefox, despite the warning), or via an http server that is inaccessible from the internet (like on your schools network with no port forwarding). A quick google search turns up several answers that would work for this.

I request that you take down your internet facing copies of the game ASAP.

AlexandruSimandi commented 6 years ago

@Jcw87 We aren't allowed to run even a modified version? You added no license...

Jcw87 commented 6 years ago

I didn't add a license because I couldn't find one that I liked. Most countries default to restricting a bunch of stuff, so that works well enough for me.

What I'm most concerned about is people uploading identical or near-identical copies of the game and directing traffic toward that instead of here. In the case of the sans fight, there was someone who uploaded it with no changes to their own github page, and not only managed to beat out mine in the google search rankings, but made mine almost vanish entirely, which is pretty fucked. Playing it here means that when if/when I update it, people can play the updated version, instead of some guys never-updating copy.

The source is on github in case someone wants to add new features or fix and improve things themselves, However, nobody seems to be interested in adding or improving. The only replace assets, which inevitably goes against the core idea of the project. I also don't mind if people want to take PARTS of the code and use it in their own projects. It's the wholesale effortless copying that bothers me.

AlexandruSimandi commented 6 years ago

@Jcw87 I just want to replace some assets and text to make fun of my corrupt government, is that ok?