Closed sergiopaniego closed 5 years ago
I have reviewed the changes and tested part of the functionality. The following list shows the changes that are tested and working.
Changes left to test:
When I test this last point, we will be able to accept and merge the pull request. Apart from the functionality, I think it would be important to work on two points in order to improve the quality of the pull request:
Code quality: I think it would be important to revisit the code and refactor part of it before merging.
Documentation: I think the documentation should also be updated with the new functionality. This should be done in the new GitHub Pages project's web under the docs folder. In this documentation, the new functionality should be explained with easy to understand examples. The videos done during GSoC could be added in the examples but a written step by step explanation of the .procedure would also be interesting.
I have updated DetectionSuite's webpage with a brief description about the new included features. I think it's interesting including this information for new users to get easily familiar with the tool.
This pull requests is intended to add all the work done by @sleep-404 during GSoC-19. This changes are taken from the official repo and they are described in the blog.
I have not added any modification in the work done by @sleep-404. Created to solve #146