search

JdeRobot / ObjectDetector

16 stars 14 forks source link

Create a PIP official package of this node #32

Closed jmplaza closed 4 years ago

jmplaza commented 6 years ago

Maybe naming it jderobot-objectdetector to avoid collision with other packages

ayushmankumar7 commented 4 years ago

I am Working on this.

ayushmankumar7 commented 4 years ago

I was tried creating a pip package. Please check my PR.

naxvm commented 4 years ago

Thank you for your contribution Ayushman! We have merged the changes into the master branch. However we are currently migrating this node to work with Python 3 and ROS Melodic (#47), so maybe we have to re-build the package again when this is complete. As I checked, the pip package you configured is suitable for Python 2, but would be great if you want to re-build the package with Python3!

ayushmankumar7 commented 4 years ago

Sure ! I am rebuilding it for Python3 then.