search

JdeRobot / PyOnArduino

4 stars 2 forks source link

Fix linting and other PEP8 convention inconsistencies #20

Closed agshubhs closed 5 years ago

agshubhs commented 5 years ago

This PR makes the following changes:

  1. Deleted the IDE configuration directory (.idea/) from the repository and added it's entry to .gitignore.
  2. Rename Modules and packages across the repository to follow PEP 8 naming convention.
  3. Rename variables which shadow builtin types.
  4. Delete unused local variables and correct import statements in translator/translator.py.

These changes would help maintain consistency with the PEP 8 conventions which might get harder during the later stages of development.

sergiopaniego commented 5 years ago

We can't apply these changes. Please open an issue before starting to code in order to discuss the suitability of certain changes. We are not looking for these changes.